-
Notifications
You must be signed in to change notification settings - Fork 54
Update vi-vn.json #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vi-vn.json #160
Conversation
Add translations of the latest strings.
Update lastest strings
Summary of ChangesHello @honhatduy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands and refines the Vietnamese localization of the application. It introduces a suite of new translation keys to support recently added features or UI components, such as detailed playlist entry counts, configuration options for visible tabs, and comprehensive file and folder management messages. Additionally, several existing strings have been updated to ensure the Vietnamese interface is as accurate and user-friendly as possible, providing a more complete and polished experience for Vietnamese-speaking users. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Vietnamese localization file (vi_VN.json) by adding new translations and translating existing English strings. The changes are mostly good, but I've found a few issues. Most importantly, there is a JSON syntax error that would break the application. I've also pointed out several inconsistencies in terminology and formatting (e.g., separators and the word for 'file'), and one untranslated string. My review comments include specific suggestions to fix these issues, which will improve the quality and consistency of the localization file.
honhatduy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
Edited symbol
honhatduy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edited symbol
honhatduy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added it ;)
|
Thanks! I recently wrote this CI to translate few things with ChatGPT, but it does make mistakes. |
Yes, I see something wrong with ChatGPT's suggestions. |
Update lastest strings