Fix COLR glyph extents calculations#158
Merged
LaurenzV merged 5 commits intoharfbuzz:mainfrom Mar 9, 2025
Merged
Conversation
cfa26ae to
2afbe91
Compare
They are *currently* not calculated correctly, but that's a ttf-parser issue (harfbuzz/ttf-parser#185)
harfbuzz/harfbuzz@ed63626 harfbuzz/harfbuzz@540666b This doesn't fix any COLR tests in and of itself.
Collaborator
|
That seems good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added custom tests for COLR glyph extents using the font mentioned in the TODO (see #157). Many of the tests failed, so I fixed the bugs causing them to do so:
union_andintersectmethods were copied incorrectly from HarfBuzz and overwrote the destination bounds entirely.push_clipis called. This doesn't seem to affect any tests, but I ran into it while tracking down the harder-to-spot first issue (union_andintersect).