Merged
Conversation
Contributor
|
I have no problem with this. Dependncy update aside, the module could stand to be made more efficient, mostly by caching the VM instance to avoid creating a new one for every call to The API could definitely be improved, however, but this is something from harfbuzz's PoV, really. |
LaurenzV
approved these changes
Mar 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wasmi dependency is only used for the non-default WASM shaper featuer. I built and ran tests with this so it is probably fine, but @asibahi I thought I'd run this by you to make sure there isn't some reason to hold this back.
This will need a lock file bump to go with it, but I'll sort that out on merge dependency on #152 and #153.