Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This project was initially approved last week until I got a message from the TSE that reviewed it via slack, which he says, there was no integration test added to the project, which I said I would add it. While it was approved, I had merged to the master branch and request for a new partner for the Javascript curriculum, and I was repaired.
Yesterday, I checked my dashboard, and discovered the status of the project had been changed from "Assignement Completed" to "changes requested", I added the changes he requested, and told him about it. I also made him realize I couldn't able to make a pull request because of the merges I had done from the feature branch to the master branch, this is why I made the feature branch the base, from to be able to create this pull request, which is not professional.
Kindly check the integration test I had added in the master branch, thank you.