fix(ratewise): 收斂生產治理與 fallback 匯率快照#393
Open
s123104 wants to merge 16 commits into
Open
Conversation
Contributor
Dependency ReviewThe following issues were found:
License Issues.github/workflows/ratewise-production-governance.yml
OpenSSF Scorecard
Scanned Files
|
Contributor
Lighthouse Production Baseline ✅
檢查細節
|
Contributor
|
✅ SEO 審計通過！所有 2026 標準驗證項目都符合要求。
|
added 9 commits
May 13, 2026 02:20
- 修正測試檔動態 import type annotation 警告 - 新增生產治理 spec 與 implementation plan - 恢復 RateWise lint 0 warning 品質閘門 測試：pnpm --filter @app/ratewise lint；pnpm --filter @app/ratewise typecheck
- 將內部展示與測試頁排除於 production route surface - 補 route surface 測試，避免 prerender 與 app shell 漂移 - 同步 TypeScript / Node SEO path SSOT，並新增 changeset 測試：route surface、seo public surface、prerender、typecheck、build
- 將 unhandled rejection 改為集中分類 - 限制 production hydration suppression，避免遮蔽真錯誤 - 補 chunk、history 404 與 generic fetch 分類測試 測試：errorClassification、chunkLoadRecovery、sw、pwa recovery、typecheck
- 將核心無障礙與離線體驗納入可執行驗證 - 加入 scheduled production governance workflow - 將趨勢圖 latency budget 改為明確手動與排程 gate 測試：accessibility e2e、offline indicator e2e、trend latency e2e、typecheck、workflow prettier
- 拆分 live data、deterministic generation 與 artifact verify scripts - 移除本機 Lighthouse 與 tsbuildinfo 產物追蹤 - 同步 README、AGENTS 與 CLAUDE 的 artifact policy 測試：build-scripts vitest、verify:artifacts、generate:deterministic、typecheck、prettier
- 將幣別落地頁 route registration 收斂到 registry - 補齊 SEO paths、page entry 與 routes 消費的 parity tests - 同步 production route surface 測試期望與稽核紀錄 測試：currency route registry vitest、seo paths vitest、route surface vitest、verify:ssot、typecheck
- 將 color-scheme 測試改為確認 production 不輸出 internal-only HTML - 同步 002 稽核紀錄 測試：prerender vitest、pnpm test、build:ratewise
- prebuild 不再刷新 tracked live rate data - refresh:fallback-rates 更新 build-time fallback snapshot - runtime fallback 改讀 build-time snapshot SSOT 測試：pnpm test；typecheck；build；format；diff check
- 多幣別三態切換改用 pair-level availability - 修正換錢所反向 TWD 與 spot-only label 漂移 測試：focused MultiConverter/useCurrencyConverter vitest；ratewise typecheck - pnpm format；git diff --check；pnpm test；pnpm --filter @app/ratewise build
s123104
force-pushed
the
chore/ratewise-production-governance
branch
from
cd8d1da to
4527f53
Compare
Contributor
|
✅ SEO 審計通過！所有 2026 標準驗證項目都符合要求。
|
- 提升多幣別匯率資訊文字對比 - 讓主要滾動區域可鍵盤聚焦 - 補上 AppLayout 回歸測試並同步 changeset 與 002 紀錄 測試：pnpm --filter @app/ratewise typecheck 測試：pnpm --filter @app/ratewise exec vitest run AppLayout.safe-area.test.tsx MultiConverter.test.tsx 測試：pnpm --filter @app/ratewise build 測試：Playwright 多幣別 accessibility desktop/mobile 測試：pnpm format；git diff --check
Contributor
|
✅ SEO 審計通過！所有 2026 標準驗證項目都符合要求。
|
- 修正 GA4 E2E 對建置 runtime 的誤判 - 修正 Firefox offline 測試呼叫 Chromium-only CDP 的失敗 測試：pnpm --filter @app/ratewise test:e2e；pnpm --filter @app/ratewise typecheck
Contributor
|
✅ SEO 審計通過！所有 2026 標準驗證項目都符合要求。
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d358efda7c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- 線上遠端匯率來源全失敗且無快取時改用 build-time snapshot - 更新 RateWise 與 exchangeRateService 回歸測試 測試：pnpm --filter @app/ratewise test；pnpm --filter @app/ratewise typecheck
Contributor
|
✅ SEO 審計通過！所有 2026 標準驗證項目都符合要求。
|
- SSG 金額頁注入改讀 build-time fallback snapshot - 補上 clean checkout 與 prerender 回歸測試保護 測試：vitest build-scripts/prerender；typecheck；build（無 public/rates.json）
Contributor
|
✅ SEO 審計通過！所有 2026 標準驗證項目都符合要求。
|
added 2 commits
May 13, 2026 14:02
- 更新 build-time fallback snapshot 至最新台銀快照 - 修正刷新腳本說明與幣別數量輸出 測試：build-scripts vitest；typecheck；verify-ssot-sync；git diff --check
Contributor
|
✅ SEO 審計通過！所有 2026 標準驗證項目都符合要求。
|
- 移除每日匯率資料 PR 的 workflow 直接合併步驟 - 改由 branch protection 與 GitHub 原生合併控制接手 - 補上 workflow 回歸測試與治理文件 測試：build-scripts vitest；typecheck；verify-ssot-sync；git diff --check
Contributor
|
✅ SEO 審計通過！所有 2026 標準驗證項目都符合要求。
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
摘要
影響
驗證
Review thread 狀態