Example Python file and README Update #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A function was added to keyboard_and_video.py (get_file_path), that creates a file path based on the OS you're running on. Recording and image taking was updated to use these functions.
Instruction for installing mplayer in 3 major environments was added, along with placing an example for using video_and_keyboard.py.
Walt-H
commented
Oct 30, 2020
Author
Walt-H
left a comment
Walt-H
left a comment
There was a problem hiding this comment.
I think it's looking good :D
Any thoughts hanyazou?
This was referenced Nov 16, 2020
|
sry but I tried your "made_keyboard_and_video.py platform neutral" version for Ubuntu 18.04 incl. your advices from readme.txt (installing the player) but it did not work. still black screen with battery status etc. on the upper left. do you have any tipps for me? |
Hi, I have the same problem on Windows10. Have you solved it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi hanyazou,
I am a very big fan of your work, and I am very thankful for your Python Tello client :D !!
With a lot of people having questions about mplayer and video_and_keyboard.py, I wanted to contribute solutions that have helped me and others who have reported similar issues.
First, with people typically using video_and_keyboard.py first, I made the example code platform independent for when users want to save an image or video.
Lastly, since all video examples assume mplayer is installed, I added sections to help users install it based on each major platform.
Hope all is well during this time!
Best,
Walt