Skip to content

Conversation

@sequba
Copy link
Contributor

@sequba sequba commented Jan 15, 2025

Context

Merge develop to master to deploy documentation and fix #1480 and #1481

How did you test your changes?

local docs build

Related issues:

Fixes #1480
Fixes #1481

sequba and others added 3 commits January 14, 2025 11:48
Make code examples check for registered languages before registering new ones
…loading addons is disabled` (#1486)

Migrate mortgage-calculator demo in readme from Codestandbox to Stackblitz
@sequba sequba self-assigned this Jan 15, 2025
@sequba sequba marked this pull request as ready for review January 15, 2025 15:43
@codecov
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.22%. Comparing base (a2a3e6f) to head (f392eae).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1487   +/-   ##
=======================================
  Coverage   97.22%   97.22%           
=======================================
  Files         169      169           
  Lines       14523    14523           
  Branches     3080     3080           
=======================================
  Hits        14120    14120           
  Misses        403      403           

@github-actions
Copy link

github-actions bot commented Jan 15, 2025

Performance comparison of head (f392eae) vs base (a2a3e6f)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 512.46 | 523.05 | +2.07%
                                      Sheet B | 169.59 | 166.13 | -2.04%
                                      Sheet T | 147.87 |    145 | -1.94%
                                Column ranges | 518.89 | 516.44 | -0.47%
Sheet A:  change value, add/remove row/column |  14.51 |  14.53 | +0.14%
 Sheet B: change value, add/remove row/column |  139.9 | 135.22 | -3.35%
                   Column ranges - add column |    162 | 159.22 | -1.72%
                Column ranges - without batch | 479.06 | 457.84 | -4.43%
                        Column ranges - batch | 119.95 | 114.73 | -4.35%

@sequba sequba merged commit 469c9dd into master Jan 15, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Language already registered error in the i18n demo when switching between docs pages [Bug]: Mortgage demo in readme does not work

2 participants