Open
Conversation
Author
|
@jaylinski pls review! |
There was a problem hiding this comment.
Pull request overview
This PR converts the package’s build/test setup to publish and consume a single ESM build output (dist/index.js) and updates the toolchain configuration accordingly.
Changes:
- Update TypeScript and ESLint targets to ES2022 and emit ES2022 modules into
dist/. - Simplify
package.jsonexports to a single default ESM entry and remove the CJS build pipeline. - Update specs to import from
../dist/index.jsand drop Node 18 from CI/engines.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tsconfig.json |
Moves compilation target/module to ES2022 and emits into dist/. |
package.json |
Switches to a single ESM export/build output; adjusts build scripts, engines, and published files. |
spec/visitor.js |
Updates test import path to new dist entry. |
spec/utils.js |
Updates test import path to new dist entry. |
spec/parser.js |
Updates test import path to new dist entry. |
spec/ast.js |
Updates test import path to new dist entry. |
.github/workflows/ci.yml |
Removes Node 18 from the test matrix. |
.eslintrc.cjs |
Updates ESLint ecmaVersion to 2022. |
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:48
- The matrix key is spelled
node-vesion. While it currently works because it’s referenced consistently, the typo makes the workflow harder to understand and easier to mis-edit later. Rename the key tonode-versionand update the${{ matrix.* }}reference accordingly.
strategy:
matrix:
node-vesion:
- 20
- 22
- 24
steps:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
- uses: actions/setup-node@v4
with:
cache: pnpm
node-version: ${{matrix.node-vesion}}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.