Use assets config path relative to app root in assets command#381
Merged
timriley merged 2 commits intohanami:mainfrom Feb 6, 2026
Merged
Use assets config path relative to app root in assets command#381timriley merged 2 commits intohanami:mainfrom
timriley merged 2 commits intohanami:mainfrom
Conversation
Contributor
|
ℹ️ Optional job failed: Ruby jruby |
Member
|
Thanks @haileys! This looks like a fair change to me, and I'd be happy if we can support your setup :) Looks like the tests are failing due to the changed paths. Would you mind adjusting those? |
haileys
force-pushed
the
assets-config-relative-path
branch
from
1af6dd0 to
a577fc5
Compare
haileys
force-pushed
the
assets-config-relative-path
branch
from
a577fc5 to
bee56aa
Compare
Member
|
Thanks again @haileys! I'm going to release this today to help you stay unblocked :) |
timriley
pushed a commit
that referenced
this pull request
Feb 6, 2026
Member
|
Released in v2.3.5 🎉 |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A little context first because this is a weird one: I have a somewhat ..unorthodox node.js setup on my dev machines where
node,npm, etc. are wrapper scripts that transparently run node stuff in a container where only the essentials are mounted in. Usually this just works, and surprisingly well too, but it does mean that workspace path node sees is not the same as the workspace path outside of the container. Most stuff I run seems to use relative paths so this hasn't really been an issue.The
hanami assetscommand invokes node with an absolute path however, and my weird setup breaks. I did a bit of digging and it looks like assets-js already assumes cwd == app.root, so I think it should be safe also assume cwd == app.root here in the assets command, and invoke node with a path relative to the app root.