Skip to content

Refactor file conflict tests#321

Open
stephannv wants to merge 1 commit intohanami:mainfrom
stephannv:refactor_file_conflict_tests
Open

Refactor file conflict tests#321
stephannv wants to merge 1 commit intohanami:mainfrom
stephannv:refactor_file_conflict_tests

Conversation

@stephannv
Copy link
Contributor

Follow up #319

As Tim said and I agree:

All these tests for file conflict handling, spread across each generator, get pretty repetitious. [...] I think my preference would be not to worry about testing for conflicts in every generator spec, instead add e.g. a spec/unit/hanami/cli/commands/app/generate/file_conflict_handling_spec.rb that demonstrates the conflict handling for just one of the generators, which would be sufficient for us to know the code is doing what it needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant