Prevent event from bubbling up for children elements with individual hammer instances#47
Open
lfre wants to merge 1 commit intohammerjs:masterfrom
Open
Prevent event from bubbling up for children elements with individual hammer instances#47lfre wants to merge 1 commit intohammerjs:masterfrom
lfre wants to merge 1 commit intohammerjs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This handles the scenario when there's a parent hammer instance delegating events, and a chid with another hammer instance triggers a parent's delegated event with the child's data. For example:
Setup:
Steps:
This is useful for plugin-like functionality when a file wants to bind hammer events to elements, but in a specific context the element might already have a parent with a delegating hammer instance.