fix(MouseInput): check the pressed button with ev.button property instead of ev.which#981
Open
Paul167 wants to merge 1 commit intohammerjs:masterfrom
Open
fix(MouseInput): check the pressed button with ev.button property instead of ev.which#981Paul167 wants to merge 1 commit intohammerjs:masterfrom
Paul167 wants to merge 1 commit intohammerjs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #976. This replaces the non-standard MouseEvent.which property check with the recommended MouseEvent.button.
Tested on OSX 10.11.4: Chrome 50, WebDriver (ChromeDriver) 2.19, Safari 9.1, Firefox 46; Windows 7: IE11, Chrome 50.