fflogs: user_auth: Fix key path creation #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the directory where the keys are to be stored doesn't exist, all the
directories leading to that path need to be created. The check if the
path exists checks the existence correctly, but the filename itself was
also created as a directory leading to user mode being unusable with the
following error:
File "fflogsapi/user_auth.py", line 105, in _generate_ss_x509_cert
with open(self.KEY_PATH, 'wb') as f:
^^^^^^^^^^^^^^^^^^^^^^^^^
IsADirectoryError: [Errno 21] Is a directory: './fflogsapi/fflogs_auth_redirect_key.pem'
Fix this by running os.makedirs() on the dirname, and not the full path.
While at it, fix the message telling the user to press "any key", as
"any key" does not complete the input() call.
Signed-off-by: Vaal Safili <vaal.safili@gmail.com>
halworsen
approved these changes
Nov 12, 2024
Owner
halworsen
left a comment
halworsen
left a comment
There was a problem hiding this comment.
Nice catch, thanks. I'll stage a patch version and publish it 😃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the directory where the keys are to be stored doesn't exist, all the directories leading to that path need to be created. The check if the path exists checks the existence correctly, but the filename itself was also created as a directory leading to user mode being unusable with the following error:
File "fflogsapi/user_auth.py", line 105, in _generate_ss_x509_cert
with open(self.KEY_PATH, 'wb') as f:
^^^^^^^^^^^^^^^^^^^^^^^^^
IsADirectoryError: [Errno 21] Is a directory: './fflogsapi/fflogs_auth_redirect_key.pem'
Fix this by running os.makedirs() on the dirname, and not the full path.
While at it, fix the message telling the user to press "any key", as "any key" does not complete the input() call.