Peer Review #2
Open
Peer Review #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off, the code appears to non-functional, despite *some tests passing.
I will run the code and demonstrate. The UI does not properly update, leading me to be unable to do anything. The UI also appears to be unable to render anything besides these buttons. There is also a lack of documentation for FleetAnalyzer and ShipYard, which appears to be nonfunctional. Multiplayer client also appears to be completely unused. I could not find a way to initiate multiple games at once. Finally, the files could be separated into a Client, Common, and Server folders to follow the MVC design patter and make the code easier to read. I do like how it is organized between network, subsystems, and utilities though. Overall the project has potential, but there appear to be errors and a lack of documentation.