Merged
Conversation
…better with useMargins false and true, but only while useTextIconsInMargin=false. Tackling useTextIconsInMargin=true is the next step.
…th map boundaries and simplify logic for text and icon positioning, goes for both left and right edge. Still the logo needs some better vertical adjustment though.
…mode to ensure proper placement within page boundaries.
…n page boundaries.
…, ensure that these lines count into the total height of the textbox.
…g, not just add +1, since the string may include more than 1 newline.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Closed
Closed
jesade-vbg
approved these changes
Apr 13, 2026
Contributor
jesade-vbg
left a comment
jesade-vbg
left a comment
There was a problem hiding this comment.
Looks good and works good! :) Good work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turned out to be a larger fix than expected, hence the PR. Closes #1792, also discussed in #1777 (comment).