Scope integration discovery to custom_components#8967
Open
kingpanther13 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
scripts/helpers/integration_path.pylocates a submission's integration bywalking the entire clone for
*manifest.jsonand exiting with "No manifest"unless exactly one exists. The publishing documentation scopes the structure
rule to
ROOT_OF_THE_REPO/custom_components/("there can only be onesubdirectory to
ROOT_OF_THE_REPO/custom_components/"), so a repository thatsatisfies the documented rule but also ships other legitimately-named
manifest.jsonfiles (a Supervisor add-on's inner component, test fixtures)fails the Hassfest check before hassfest runs. Reproducer: #8966 - one
integration under
custom_components/, plus add-on and fixture manifestselsewhere; the HACS action itself passes on that repository.
This change scopes the search to
ROOT/custom_components/when thatdirectory exists and keeps the current whole-clone behavior otherwise
(
content_in_rootrepositories are unaffected). Repositories with multipleintegrations under
custom_components/still fail exactly as today. Verifiedagainst both shapes locally.
If the whole-clone uniqueness is intentional, happy to close this - guidance
on how monorepo-shaped repositories (integration + Supervisor add-on in one
repo) should submit would then be appreciated.