Moved and refactored the burger menue for the sidebar - solves #110#112
Merged
Conversation
Signed-off-by: Kai Wagner <kai.wagner@percona.com>
There was a problem hiding this comment.
Pull request overview
This PR resolves issue #110 by consolidating the sidebar toggle control into the global header navigation: the header “burger” now calls sidebar#toggleMobile, which correctly toggles collapse/expand on desktop and opens/closes the drawer on mobile. As part of that consolidation, the per-page/sidebar-local burger buttons and their associated styling are removed.
Changes:
- Removed the sidebar burger buttons previously embedded in Topics index/show views.
- Removed the sidebar-local “toggle bar” from the sidebar layout, making the header nav burger the single toggle entry point.
- Updated styling so the header nav burger is shown whenever a sidebar is present, and removed the now-unused sidebar burger CSS.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| app/views/topics/show.html.slim | Removes the topic-header embedded sidebar burger button. |
| app/views/topics/index.html.slim | Removes the topics table-header embedded sidebar burger button. |
| app/views/layouts/application.html.slim | Removes the sidebar-local toggle bar/button from the sidebar container. |
| app/assets/stylesheets/layouts/topic-view.css | Removes collapsed-sidebar display rule for the removed topic-view burger button. |
| app/assets/stylesheets/components/topics.css | Removes collapsed-sidebar display rule for the removed topics-table burger button. |
| app/assets/stylesheets/components/sidebar.css | Removes styling for the removed sidebar burger button and toggle bar container. |
| app/assets/stylesheets/components/navigation.css | Ensures the header nav burger displays whenever body.has-sidebar is present (not only in the mobile media query). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
moozzi
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header burger now uses sidebar#toggleMobile, which already correctly routes to collapse()/expand() on desktop and the slide-in drawer on mobile.
Unified view, always at the same spot and works from all pages now.
Resolves #110