HCK-15551: improve view column comments#330
Merged
Vitalii4as merged 3 commits intodevelopfrom Apr 9, 2026
Merged
Conversation
|
Vitalii4as
reviewed
Apr 9, 2026
| columnList.push({ | ||
| name: `${prepareName(name)}`, | ||
| comment: property.description, | ||
| comment: property.refDescription || property.description, |
Contributor
There was a problem hiding this comment.
Shouldn't we consider only refDescription when the column is a reference? For example If you have a table column with some comment, but in your view column (that references table column) you don't want to have a comment. It won't be possible to achieve with this code, because it will assign the description of definition as comment of view column.
Contributor
Author
There was a problem hiding this comment.
Yes, that's a valid use case.
We took a safe way for this change for now.
We may discuss it separately. It may indeed be better to use only refDescription for references.
Vitalii4as
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
refDescription) over definition descriptions (description) for view column referencesrefDescriptionto the script generation options configuration, enabling it to work alongside the existingdescriptionproperty