Removing html elements from events description.#19
Removing html elements from events description.#19edenxcodes wants to merge 1 commit intohackgvl:devfrom
Conversation
oliviasculley
left a comment
oliviasculley
left a comment
There was a problem hiding this comment.
I'm using the emoji code review standard, so ⛏️ represents comments that don't necessarily need to be changed and 🔧 needs to be changed. Since the only item that should be changed is relatively minor (the private function naming), i've gone ahead and approved this PR so it can be merged in once the changes have been made!
Thank you for contributing!!
| # import regular expression module | ||
| import re | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
⛏️ There isn't a big need for this import to be separate from the other imports, and I think the comment isn't totally necessary
|
|
||
|
|
There was a problem hiding this comment.
⛏️ These lines can be removed
| self.description = self.remove_html(description) | ||
| self.location = location | ||
| self.time = time | ||
| self.url = url | ||
| self.status = status | ||
| self.uuid = uuid | ||
|
|
||
| def remove_html(self, string): |
There was a problem hiding this comment.
| self.description = self.remove_html(description) | |
| self.location = location | |
| self.time = time | |
| self.url = url | |
| self.status = status | |
| self.uuid = uuid | |
| def remove_html(self, string): | |
| self.description = self.__remove_html(description) | |
| self.location = location | |
| self.time = time | |
| self.url = url | |
| self.status = status | |
| self.uuid = uuid | |
| def __remove_html(self, string): |
🔧 Since this function is only intended to be used in Event's __init__ constructor, we'll want to add two underscores in order to mark this as a private function that isn't intended to be used by other people. But otherwise, separating the HTML sanitation into a separate function is a great approach!
|
Oh also let me know your preferred information so we can add you to the list of contributors in the README! |
|
Hi @oliviasculley, thanks a bunch for the feedbacks. |
|
I don't have a twitter, but I'm active on the HackGreenville slack group at https://hackgreenville.com. @all-contributors please add @edenxcodes for code ! |
|
I've put up a pull request to add @edenxcodes! 🎉 |
|
Hi @oliviasculley, my profile isn't showing on the contributors list yet xD. Do I have to accept it or something? (pardon my ask, I'm new to open source contributions :D ). |
|
We'll need to get this PR merged into dev first, and then we should be able to add the contributors PR after that. Will you be at the first Hackgreenville Nights this Thursday? We can do some pair programming to get this PR passing all the tests, it should be pretty quick so we won't need to miss any talks or anything |
|
Hello @edenxcodes! 😄 I wanted to check in to see if there was any way I could support you in helping to get this PR ready to rock. I think aside from the merge conflict it's pretty much ready to 🚢. I'm off work this Friday and have some availability if you'd like to collaborate at any point during the day. Just let me know and I'd be down to get something together! |
4 participants
Closes hackgvl/hackgreenville-com#682