-
Notifications
You must be signed in to change notification settings - Fork 16
Complete Bootstrap to Tailwind CSS Migration & Form System Modernization #601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
- Install pint globally and create symlink to fix error code 127 - Migrate from SASS to CSS imports to eliminate deprecation warnings - Create third-party.css for external dependencies (fullcalendar, sweetalert2) - Update vite config and blade templates to use CSS instead of SCSS - Remove broken ide-helper commands from lint script - All lint checks now pass without errors
- Remove problematic pint symlink - Add PHP_VERSION_REQUIREMENT.md documenting PHP 8.1-8.3 requirement - Restore all missing homepage styles including background image - Add footer, button, and typography styles that were missing - Fix banner image path to use Vite-processed asset - Preserve original visual appearance while using Tailwind base
allella
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is my first run-through of questions.
a33a5ba to
878c8f2
Compare
- Resolves CI test failure where lock file version didn't match composer.json requirement - Updated glhd/aire from 2.13.0 to 2.14.0 to satisfy ^2.14 constraint - Lock file now in sync with composer.json after merge from develop
|
I just resolved the merge conflicts |
|
@beetz12 Overall, this looks good with no major issues that I see. I did a first pass through with the live database imported on localhost, and here are minor styling items of note. Underlining of Linked Buttonstype="button"These tags with type="button" show an underlined styling of the text, which differs from the current site. On the /hg-night page, the "Submit a Talk" and "Join our Meetup Group" buttons. Other Buttons ImpactedThis underlining also happens on the "Subscribe" button on the /events and /calendar pages, though it doesn't use the same type="button".
HG Nights Page Call to Action Box WidthOn the /hg-nights page, the two call to action boxes at the top aren't as wide as the event summary boxes below, which creates an odd appearance in the web browser. Homepage TimelineOn the homepage, the timeline of "Upcoming Events" shows a green calendar icon which does not show in the Bootstrap theme, but that's because the code, oddly, uses a "display:none" to hide it. I don't think we need the green icon there, so unless it's going to mess up some other part of the site, we could remove the following from the view / Blade file.
Homepage Timeline Vertical Line PositioningOn the same homepage timeline, there's a stylized vertical line that's showing to the left of the timeline on the Bootstrap site. This appears to be a CSS styling using .timeline:before On the Tailwind version the vertical line is showing to the right side and is overlapping other elements of the timeline.
Footer Icon AlignmentThe "Links" and "Other Links" in the footer had left alignment in Bootstrap and appear to have a center alignment in the new Tailwind version. The left alignment feels more appropriate in my opinion.
Missing Jumbotron Image on HG Labs PageThe div id="#jumbotron-image" in Bootstrap had a CSS background image. This is missing in Tailwind. The CSS for that image targeted a /img/labs.png as seen in resources/sass/labs.scss
Bulleted List Margin on About PageThe Bootstrap site had a 2em margin on the
Contribute Page Call to Action AlignmentThe top section was previously left aligned in the Bootstrap site and is center aligned in Tailwind. Since the other pages primarily use left alignment in this section, maintaining left aligning on /contribute seems appropriate.
|
|
I will confirm many of the findings from @allella. In particular, seeing several styling inconsistencies. The largest one being the calendar alignment issue on the homepage that @allella posted above. I'm seeing the
I'm also seeing the active page is not being highlighted in the Tailwind version.
A positive improvement I see is on the
One last thing I have is that I needed to use But, I will agree with Jim that this is excellent work and overall this looks really good, there's some regressions with the stylings I would like to see resolved but I appreciate the hard work put into this PR! |
|
@irby we had to run yarn install on dev, and in a stage test, so that may be a deployment gotcha note if the deploy process doesn't do the trick. |
|
@allella thanks for the detailed review. I'll get these resolved this week! |
|
@allella I just updated the site with the changes. Please review and let me know if you need anything else. |
|
@beetz12 Things look good on the browser side related to the suggestions I shared. Matt's suggestion to highlight the main header I've asked Zach Robichaud to give the PR a technical review. As a side note, I also like the wider "hero" image on the new /hg-nights page. This could be another PR, but having the same header on the /labs page would be nice for consistency, as the two pages have always been inconsistent. I can find a higher resolution photo of that existing image, or something comparable, if we want to add that sort of change into this PR. Thanks |
|
@allella thanks for the update! Sorry for the late response, it's been a busy week. No problem, I'll add highlighting for the main header .nav-link active navigation in #FFF. I'm not sure if I understand the "wider "hero" image on the new /hg-nights page.", In my PR, I made the /labs page and home page look the same as our current pages. I do think it's a great idea to make them look consistent, and I'm happy to help. But I would prefer if we create a new PR for this feature - it would be great to look back on this PR in the future and know that all changes are related to the Tailwind migration. Thoughts? |
|
@allella @zach2825 I just remove the remaining references to bootstrap styles and added "highlight the main header .nav-link active navigation in #FFF color". I also made some responsive layout fixes to the header and the /labs page. Please review, and let me know if you want to make any other changes. |
|
Thanks @beetz12 It still looks good on localhost with production data testing. I think the main thing now is getting our new stage and production server setup on Railway. I'll ping Bogdan to see if we're close to getting that finalized, or if we need to go find a middle-ground to keep things moving. |
|
That's great @allella. I'll defer to you and Bogdan on the server setup. Just FYI, I'm also experienced with railway and I could also help with setup if needed. I'll be at to Openworks most days now so we could meet there to knock it out. |
zach2825
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 looks great 💯
|
@zach2825 great, thanks for the review! |
Fixed "lockfile needs to be updated" error by running yarn install to synchronize yarn.lock with package.json changes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>













This PR completes the full migration from Bootstrap to Tailwind CSS across the entire
HackGreenville.com codebase, removes all Bootstrap-related dependencies, and modernizes the
form system by replacing the deprecated aire-bootstrap package with standard Laravel Blade
forms styled with Tailwind CSS.
Changes Made
Navigation & Layout Fixes
Complete Page Migrations from Bootstrap to Tailwind
Homepage (index.blade.php):
to Tailwind utilities
Error Pages (404.blade.php, 500.blade.php):
Organization Pages:
Flexbox
Calendar Feed (calendar-feed/index.blade.php):
Form Submission Pages:
Calendar Page (calendar/index.blade.php):
Form System Modernization
with Tailwind styling
button
Build System Updates
Dependency Management
CSS Architecture
Technical Details
Form Migration Strategy
Instead of using another form builder package, we opted for standard Laravel Blade forms
with Tailwind styling because:
Error Resolution
Testing Performed
Breaking Changes
None - all changes maintain backward compatibility and visual parity.
Migration Checklist
Notes
Update 8/8/25:
CSS classes
cleaner, more maintainable syntax
allow custom validation
(name, email, checkbox)
for reliability
field validity