Starts implementation for --force system & establishes naming consistency#1161
Starts implementation for --force system & establishes naming consistency#1161jaspermayone wants to merge 3 commits intomainfrom
Conversation
|
Oh hrm this doesn't look good. |
|
Okay it seems to be having problems with paths |
grymmy
left a comment
grymmy
left a comment
There was a problem hiding this comment.
I'm fine w/ this landing but would note that the sync and sync-force workflows could, instead of being carbon copies of each other, be shared and extended via decoration using the github reusable workflow pattern. This would result in reduced LOC and ensure these workflows are kept in sync over time as changes are needed in one or the other.
|
Oh interesting I wasn't aware of that. Will implement! |
|
@jaspermayone just ping me when u want re-review |
Muirrum
left a comment
Muirrum
left a comment
There was a problem hiding this comment.
Renaming the actions is much appreciated :) lgtm!
|
Docs on --force here octodns/octodns#1170 |
|
Is there a reason this isn't merged? |
|
iirc this needed a bit more engineering work to get it over the line |
|
And bc it was me who did the initial work lol |
|
This PR has been inactive for 7 days and will be closed in another 7 days if there is no activity. If you still need this PR merged, please address the requested changes. |
|
Closing this due to it going stale with conflicts. I am accelerating the timeline because there has been no motion, even before the autoclosing of stale PRs was added. |
6 participants
This PR starts the implementation for a
--forcesystem as well as establishing some constancy for workflow/file naming.See https://hackclub.slack.com/archives/C05SVRTCDGV/p1714867674790609?thread_ts=1714613706.014109&cid=C05SVRTCDGV for why the validation flow is currently blocked, but this PR will at least establish a manual workflow unblocking the other PR's, until we establish an auto labeler / system.