Explore page (unload some devlogs to save ram)#63
Explore page (unload some devlogs to save ram)#63bbarni2020 wants to merge 2 commits intohackclub:stagingfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements a memory optimization feature for the explore page by limiting the number of loaded devlogs in memory. When the number of devlogs exceeds 60, the oldest 15 are removed (trimming back to 45) while preserving the user's scroll position.
Key changes:
- Added automatic trimming of old devlogs to prevent unlimited memory growth
- Implemented scroll position preservation when removing devlogs from the DOM
- Set maximum devlogs limit to 60 with trimming threshold at 45
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ArcaEge
left a comment
ArcaEge
left a comment
There was a problem hiding this comment.
This just gets rid of the devlogs at the top and they don't return if you scroll back up. Instead it should check the intersectionobserver and just completely unmount the Spinny3DPreview if it's scrolled way past, the devlog itself can be kept in place to avoid messing with the dom
|
Kk, on it |
|
Done |
|
I'll have a look this evening |
2 participants
No description provided.