Add tilemap modifier support for Physics Colliders#244
Open
NeoKuro wants to merge 1 commit intoh8man:masterfrom
Open
Add tilemap modifier support for Physics Colliders#244NeoKuro wants to merge 1 commit intoh8man:masterfrom
NeoKuro wants to merge 1 commit intoh8man:masterfrom
Conversation
h8man
reviewed
Feb 16, 2026
Owner
h8man
left a comment
h8man
left a comment
There was a problem hiding this comment.
Your MR mixes physics and renderer collection that will lead to problem.
Are you willing to spend some time and create a better solution with "source override" per modifier?
|
|
||
| private static void CollectTile(Tilemap tilemap, NavMeshBuilder2dState builder, Vector3Int vec3int, Vector3 size, Mesh sharedMesh, Quaternion rot, ref NavMeshBuildSource src) | ||
| { | ||
| if (!builder.overrideByGrid && tilemap.GetColliderType(vec3int) == Tile.ColliderType.Sprite) |
Owner
There was a problem hiding this comment.
There no option to collect physics from tilemap, except from collider, and collider doesn't have tilebase context.
TilemapModifier is a special case for Renderer Meshes or Boxes.
Can you describe why you need both physics and render meshes in one bake? There better and clean solution that we can implement, just use Source per Modifier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where any Tilemap Modifier component settings were ignored when
Use Geometry=Physics Colliderswas set.