use a configurable amount of worker threads to handle requests#66
Open
sharksforarms wants to merge 1 commit intoh2o:masterfrom
Open
use a configurable amount of worker threads to handle requests#66sharksforarms wants to merge 1 commit intoh2o:masterfrom
sharksforarms wants to merge 1 commit intoh2o:masterfrom
Conversation
instead of having a 1-1 mapping between application thread and neverbleed threads, wewe can configure a static pool of threads that can handle incoming requests. Using epoll features, we can have an idle thread handle the next incoming request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instead of having a 1-1 mapping between application thread and neverbleed threads, we can configure a static pool of threads that can handle incoming requests.
Using epoll features, we can have an idle thread handle the next incoming request.
In summary, there is an epoll instance per thread. The client fd is added to each thread's epoll instance with
EPOLLEXCLUSIVE, so that only a single instance will get woke when the fd is ready.For offload events, we keep these on the same thread the offload request was started on, I found that offload requests cannot be resumed on a different thread, see intel/QAT_Engine#306
Other:
pollto see if the fd is still read-able