sort matchers by extension makes matching deterministic#73
Open
sergolius wants to merge 1 commit intoh2non:masterfrom
Open
sort matchers by extension makes matching deterministic#73sergolius wants to merge 1 commit intoh2non:masterfrom
sergolius wants to merge 1 commit intoh2non:masterfrom
Conversation
|
While deterministic is better than undeterministic, shouldn't it try to match to the "most specialized" first? Like, probably change the mimetypes map to a slice of mimetypes and try to sort it manually in the best possible order. |
|
another suggestion - it could also return multiple values (so all matching): |
Owner
|
This is a good initial approach, but not enough. We need to explicitly order matchers based on the most specific first. I guess it's better to define an array that respects order on each matchers category file. A PR is very welcome! |
This was referenced Nov 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.