fix(github-token): prefer App installation token over PAT in user fallbacks#31
Open
fix(github-token): prefer App installation token over PAT in user fallbacks#31
Conversation
…lbacks When a user has no stored GitHub OAuth token (e.g., logged in via a non-GitHub OAuth provider) the cascade fell straight to the PAT, ignoring a configured GitHub App. Deployments using only an App for server-side auth therefore failed with "No GitHub token available" on every task credential request, which broke scheduled tasks at the agent's first git operation. Route all user-token fallbacks through getServerToken so the order becomes: user OAuth → App installation token → workspace PAT → global PAT. getServerToken now accepts an optional workspaceId so the PAT fallback still prefers a workspace-scoped GITHUB_TOKEN before global.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user has no stored GitHub OAuth token (e.g., logged in via a
non-GitHub OAuth provider) the cascade fell straight to the PAT,
ignoring a configured GitHub App. Deployments using only an App for
server-side auth therefore failed with "No GitHub token available" on
every task credential request, which broke scheduled tasks at the
agent's first git operation.
Route all user-token fallbacks through getServerToken so the order
becomes: user OAuth → App installation token → workspace PAT → global
PAT. getServerToken now accepts an optional workspaceId so the PAT
fallback still prefers a workspace-scoped GITHUB_TOKEN before global.
Summary
Changes
Testing
pnpm turbo test)pnpm turbo typecheck)Related
Closes #
Screenshots