Add option to remove junk radiation before evaluating polarizations#49
Draft
vaishakp wants to merge 1 commit into
Draft
Add option to remove junk radiation before evaluating polarizations#49vaishakp wants to merge 1 commit into
vaishakp wants to merge 1 commit into
Conversation
63c4495 to
2460e34
Compare
1. Add option to remove junk radiation before evaluating polarizations and make it default. 2. lint
2460e34 to
f0e16ee
Compare
Collaborator
Author
|
Tests on GT catalog failing as the Need to implement retrieving junk time with a uniform attr across catalogs |
Contributor
|
For catalogs that do not provide a |
Draft
Contributor
|
Please cherry-pick #51 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current behavior in
WaveformModes.get_td_waveformdoes not allow for removal of junk radiation from the data.This PR achieves the following:
Desirable: