Skip to content

added condition as a handle for tapering in polarization functions#5

Open
kaushikush wants to merge 2 commits intogwnrtools:masterfrom
kaushikush:master
Open

added condition as a handle for tapering in polarization functions#5
kaushikush wants to merge 2 commits intogwnrtools:masterfrom
kaushikush:master

Conversation

@kaushikush
Copy link
Copy Markdown
Collaborator

This pull request adds condition as one of the input arguments in get_imr_esigma_waveform() and get_inspiral_esigma_waveform(). This is consistent with the condition argument in the gwsignal implementation of EsigmaHM.

Setting condition==1 means the tapering is on, andcondition==0 means tapering is off. The helper function that does the tapering, is located in condition.py.

Please note that this PR implements conditioning only for polarizations, not for spherical harmonic modes.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an on/off condition flag to ESIGMA polarization waveform generators to optionally apply start-time tapering, aligning the API with gwsignal’s EsigmaHM conditioning behavior (polarizations only; not modes).

Changes:

  • Add condition parameter to get_inspiral_esigma_waveform() and get_imr_esigma_waveform().
  • Apply polarization tapering via a new helper (apply_taper_both_pols) when condition==1.
  • Introduce new esigmapy/condition.py with taper width estimation and taper application utilities.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File Description
esigmapy/generator.py Adds condition arg and conditionally applies tapering to returned polarizations.
esigmapy/condition.py New module implementing taper-width computation and taper application helpers.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants