added condition as a handle for tapering in polarization functions#5
Open
kaushikush wants to merge 2 commits intogwnrtools:masterfrom
Open
added condition as a handle for tapering in polarization functions#5kaushikush wants to merge 2 commits intogwnrtools:masterfrom
kaushikush wants to merge 2 commits intogwnrtools:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds an on/off condition flag to ESIGMA polarization waveform generators to optionally apply start-time tapering, aligning the API with gwsignal’s EsigmaHM conditioning behavior (polarizations only; not modes).
Changes:
- Add
conditionparameter toget_inspiral_esigma_waveform()andget_imr_esigma_waveform(). - Apply polarization tapering via a new helper (
apply_taper_both_pols) whencondition==1. - Introduce new
esigmapy/condition.pywith taper width estimation and taper application utilities.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
esigmapy/generator.py |
Adds condition arg and conditionally applies tapering to returned polarizations. |
esigmapy/condition.py |
New module implementing taper-width computation and taper application helpers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds
conditionas one of the input arguments inget_imr_esigma_waveform()andget_inspiral_esigma_waveform(). This is consistent with theconditionargument in thegwsignalimplementation ofEsigmaHM.Setting
condition==1means the tapering is on, andcondition==0means tapering is off. The helper function that does the tapering, is located incondition.py.Please note that this PR implements conditioning only for polarizations, not for spherical harmonic modes.