Adding a PyCBC plugin to generate ESIGMA waveforms#1
Adding a PyCBC plugin to generate ESIGMA waveforms#1divyajyoti09 wants to merge 1 commit intogwnrtools:masterfrom
Conversation
|
|
||
| if not import_os_exists or not lal_data_path_exists: | ||
| # Find the index where to insert the LAL_DATA_PATH line | ||
| insert_index = None |
There was a problem hiding this comment.
If no 'import' statements are found in esigma_utils.py, the insert_index remains None and no insertion is performed. Consider adding a fallback insertion index, such as appending to the file, to guarantee that the LAL_DATA_PATH line is inserted.
| hp_ts = TimeSeries(hp, input_params['delta_t']) | ||
| hc_ts = TimeSeries(hc, input_params['delta_t']) | ||
|
|
||
| hp_tapered = taper_signal(hp_ts) | ||
| hc_tapered = taper_signal(hc_ts) |
There was a problem hiding this comment.
[nitpick] The logic for converting the waveform output into TimeSeries and tapering is duplicated across several waveform functions. Consider refactoring the repeated logic into a common helper function to improve maintainability.
| hp_ts = TimeSeries(hp, input_params['delta_t']) | |
| hc_ts = TimeSeries(hc, input_params['delta_t']) | |
| hp_tapered = taper_signal(hp_ts) | |
| hc_tapered = taper_signal(hc_ts) | |
| hp_tapered, hc_tapered = process_waveform(hp, hc, input_params['delta_t']) |
There was a problem hiding this comment.
@divyajyoti09 This file is not needed, the plugin should be installed when this package esigmapy is installed.
There was a problem hiding this comment.
@divyajyoti09 This file is probably not needed in its current form, the plugin should be installed when this package esigmapy itself is installed.
There was a problem hiding this comment.
@divyajyoti09 add the information present here in a suitable way to the README of this project.
prayush
left a comment
prayush
left a comment
There was a problem hiding this comment.
Please see the comments above
This plugin is added to generate ESIGMA waveforms in PyCBC without additional settings or specialized PyCBC installation