Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
mkdirwithmkdirSyncincreate-pipes, so error thrown (e.g. on directory existed) would be properly caught.Currently on directory collision, the asynchronous
mkdir's error would not be caught andsync-execwould erroneously assumed the directory to exist, which could result in various error such as hanging.I know with
execSyncinherently in Node 0.12 the wise thing to do is probably to move onto that. But for various reasons I'm currently stuck with Node 0.10 andsync-execis what I'm using to polyfillexecSync.@gvarsanyi would you help review this PR?