Skip to content

Sort by feed article length#195

Merged
guyfedwards merged 5 commits into
guyfedwards:masterfrom
jbenge1:Sort_By_Feed_Article_Length
Jun 5, 2026
Merged

Sort by feed article length#195
guyfedwards merged 5 commits into
guyfedwards:masterfrom
jbenge1:Sort_By_Feed_Article_Length

Conversation

@jbenge1

@jbenge1 jbenge1 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Fixes #177 Sort by article content length (respects read/unread ordering still)

  • ordering: length
    • New value "length" settable in config.
  • unread-first still trumps length
  • sort-toggle key noops in length mode
    • Switched checking to use switch statement instead of if else if
    • Explicitly checking against Asc/Desc and default noops (Though I'm happy to have it cycle through the three ordering options if that's preferred)
    • unknown ordering values no longer coerce to asc on toggle — they noop
  • Added two tests for store.go to verify existing functionality and new functionality

Tested: go test ./... (note: TestNewDefaultWithXDGConfigHome fails on macOS regardless of this change, I'm happy to file a bug separately if folks think it's necessary), plus manual TUI verification against direct sqlite queries.

@guyfedwards guyfedwards merged commit 85739a1 into guyfedwards:master Jun 5, 2026
2 checks passed
@guyfedwards

Copy link
Copy Markdown
Owner

Awesome, thanks @jbenge1. If you could file the bug for the mac test failure that would be great thanks

@guyfedwards

Copy link
Copy Markdown
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Sort feed by article length

2 participants