feat: allow custom theme and refreshing indicator#191
Closed
Ryuuusuke wants to merge 2 commits into
Closed
Conversation
Ryuuusuke
force-pushed
the
main
branch
2 times, most recently
from
add46de to
be1a903
Compare
Owner
|
Merged in #194. Sorry @Ryuuusuke I started a review way back and never clicked submit so the comments were just stuck here. Then I messed up the merge and so just went ahead and sorted it myself. Thanks for the update, looks great 🎉 |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm making this because when I press 'r'. I don't know it's now refreshing or not. or maybe I didn't click it yet. when I clicked again, it shows error because it's still fetching and locked. So I just add refreshing indicator and also prevent refresh spamming.