Pipeline can now log and monitor how the the system is performing #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sajtospoga01
requested changes
Mar 25, 2024
|
|
||
| std::string PerformanceMonitor::getMemoryUsage() | ||
| { | ||
| std::string memoryUsage = "Memory Usage: "; |
Contributor
There was a problem hiding this comment.
Does this actually get any data?
| } | ||
|
|
||
| void ThreadLogger::logPerformance(const std::string& category, const std::string& data) { | ||
| std::ostringstream ss; |
Contributor
There was a problem hiding this comment.
Use the main log function to log messages. this is not threadsafe (hence the whole point of the logger), and using multiple methods to queue messages would not be too intuitive. You could opt to use a helper method instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced the logging capability and added the PerformanceMonitor class