Closed
Conversation
gunthercox
force-pushed
the
train
branch
2 times, most recently
from
a9e68a9 to
f3869b4
Compare
Owner
Author
|
Closing this in preference to just increasing the maximum field length (#2436). Length validation could still be good to add at some point, but maybe in a way that doesn't increase the training overhead directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds optional validation (enabled by default) when the
trainstep is called to log warnings when text in a conversation exceeds the maximum supported length.Warnings are intended to be permissive and allow the support of training data collections to exceed the default limit defined here.