Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@gulopine
The real changes here follow 994d031 (the first two commits are just #1 and #3). This PR makes the following changes beyond those two:
UnicodeColumn: it's like StringColumn, but emits Unicode (by default, UTF-8) when asked to output.FloatWithCommaSeparatorsColumn: likeFloatColumn, but handles data in which there are comma thousands-separators inside numbersBooleanColumn: mapping for columns holding true/false dataDateTimeColumn: a generalization ofDateColumnthat allows general datetimes. Extends previous functionality by also allowing multiple input formats, and the specification of a timezone into which parsed datetimes should be localized.All new column types have tests added, too, all of which pass.
Also a handful of minor PEP257 fixes around docstrings.