feat: in-editor completion / autocomplete popup by Copilot · Pull Request #157 · gui-cs/Editor

Copilot · 2026-05-17T14:27:17Z

…rovider, CompletionItem, Editor.Completion.cs, WordCompletionProvider in ted) Agent-Logs-Url: https://github.com/gui-cs/Editor/sessions/dddd5eaf-c7d7-40bb-866d-9961401a391b Co-authored-by: tig <585482+tig@users.noreply.github.com>

…decisions.md; apply jb cleanup Agent-Logs-Url: https://github.com/gui-cs/Editor/sessions/dddd5eaf-c7d7-40bb-866d-9961401a391b Co-authored-by: tig <585482+tig@users.noreply.github.com>

tig

@copilot see comments.

…ox in Settings dialog Agent-Logs-Url: https://github.com/gui-cs/Editor/sessions/cfa1ac33-d4c6-44f9-a99b-c6368a9297bd Co-authored-by: tig <585482+tig@users.noreply.github.com>

Copilot · 2026-05-17T15:47:51Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

www.jetbrains.com
- Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/.nuget/packages/jetbrains.resharper.globaltools/2026.1.1/tools/net8.0/any/cleanupcode.unix.runtimeconfig.json /home/REDACTED/.nuget/packages/jetbrains.resharper.globaltools/2026.1.1/tools/net8.0/any/cleanupcode.exe Terminal.Gui.Editor.slnx --include=examples/ted/EditorSettings.cs;examples/ted/EditorSettingsDialog.cs;examples/ted/TedApp.cs (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

tig · 2026-05-17T16:15:08Z

@copilot the setting for this on Ted is supposed to be in the first tab, not the Tabs tab of the settings dialog.

…ettings dialog Agent-Logs-Url: https://github.com/gui-cs/Editor/sessions/e681778e-94f5-49ce-a7fc-8316bcd4a183 Co-authored-by: tig <585482+tig@users.noreply.github.com>

Copilot · 2026-05-17T16:17:07Z

@copilot the setting for this on Ted is supposed to be in the first tab, not the Tabs tab of the settings dialog.

Moved the "Auto Complete (Ctrl+Space)" checkbox from the Tab Settings tab to the Config tab (first tab) in the Settings dialog. Commit 8f4d77d.

tig · 2026-05-17T16:20:41Z

@copilot read Claude.md and ensure you are following it in this pr.

…://github.com/gui-cs/Editor into copilot/add-editor-autocomplete-functionality

…s in tests Agent-Logs-Url: https://github.com/gui-cs/Editor/sessions/979aa238-ec63-48d4-8db2-5a3cac276f01 Co-authored-by: tig <585482+tig@users.noreply.github.com>

…://github.com/gui-cs/Editor into copilot/add-editor-autocomplete-functionality

tig · 2026-05-17T17:10:38Z

@copilot do not use popovermenu for autocompldete. It should be a DropDownList using Popover.

Ensure you are following CLAUDE.md.

chatgpt-codex-connector · 2026-05-17T19:44:18Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

Copilot · 2026-05-17T19:44:22Z

@copilot first, ensure you are building unit tests for these failures (that fail) before fixing:

using is in the autocomplete list
...

Added failing tests first in commit 828c17f, then fixed all three issues in commit d12c713:

Popover capturing keyboard input — Set Enabled = false on the Popover after MakeVisible so it renders the list but doesn't intercept keystrokes. All key handling (Enter/Tab/arrows/Esc) is done by HandleCompletionKey in the Editor.
Enter/Tab/arrows not routed to completion — Moved HandleCompletionKey from OnKeyDownNotHandled to OnKeyDown, which runs before command bindings. Previously, Enter triggered newline and Tab triggered indent because those bindings fired first.
Setting CompletionProvider = null didn't dismiss — Added setter logic that calls DismissCompletion() when the provider is cleared.

All 476 unit tests + 226 integration tests pass. CodeQL clean.

…lity

tig · 2026-05-17T20:59:37Z

@copilot now, when the popover is up, up/down arrow keys don't work to navigate the list.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7008d9405e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…x and ListView - Fixed arrow up/down keys updating the completion selected index correctly - Added UpdateCompletionListSelection helper for visual ListView updates - Added CompletionSelectedIndex internal property for test verification - Fixed unit tests: "unsafe" doesn't start with "us" (starts with "un") - Added ArrowDown_Wraps_To_First_Item test - Added ArrowDown_Then_Enter_Accepts_Second_Item integration test Agent-Logs-Url: https://github.com/gui-cs/Editor/sessions/ca58f879-5dc4-433d-8e77-2c1161ff8745 Co-authored-by: tig <585482+tig@users.noreply.github.com>

chatgpt-codex-connector · 2026-05-17T21:12:48Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

Copilot · 2026-05-17T21:14:28Z

@copilot now, when the popover is up, up/down arrow keys don't work to navigate the list.

Fixed in ebdb104. Arrow up/down now correctly updates both the internal selected index and the visible ListView selection via UpdateCompletionListSelection. The arrow handler directly sets _completionSelectedIndex and updates _completionListView.SelectedItem + SetNeedsDraw().

Added tests:

ArrowKeys_Navigate_Completion_Selection — Down arrow moves to second item, accept inserts it
ArrowUp_Wraps_To_Last_Item — Up from index 0 wraps to last
ArrowDown_Wraps_To_First_Item — Down from last wraps to first
ArrowDown_Then_Enter_Accepts_Second_Item — full integration test with key injection

Agent-Logs-Url: https://github.com/gui-cs/Editor/sessions/ca58f879-5dc4-433d-8e77-2c1161ff8745 Co-authored-by: tig <585482+tig@users.noreply.github.com>

chatgpt-codex-connector · 2026-05-17T21:14:43Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

tig · 2026-05-17T21:29:53Z

@copilot it's still not working. Plus when I click on a list item in the popover list, it dismisses without selecting the autocomplete item i clicked on.

Study how TextView does this and make sure you are not re-inventing how this should work. Yes, I know TextViewAutoComplete is a different beast, but it works and should show you the way.

We are going in circles here and I'm afraid you are now just hacking and playing whack-a-mole. do it right.

tig · 2026-05-17T21:51:51Z

@copilot resolve the merge conflicts in this pull request

…ar insert in HandleCompletionKey, mouse click handling via Editor.OnMouseEvent The Popover intercepts character keys internally (before KeyDown event fires), preventing them from reaching any event handler. Navigation keys (arrows) DO reach the KeyDown event. The solution: 1. Keep Enabled=false on the Popover (visual-only overlay, Editor retains focus) 2. HandleCompletionKey now handles character keys directly (insert + refresh) 3. HandleCompletionMouse detects clicks in the Popover's screen area 4. Arrow keys update ListView selection + SetNeedsDraw on both ListView and Popover 5. Backspace handled in HandleCompletionKey (remove char + refresh) This follows the PopupAutocomplete pattern from TG: the host control owns all input dispatch, the popup just renders. Agent-Logs-Url: https://github.com/gui-cs/Editor/sessions/be8ce6c1-d6d7-403d-933a-2e44aabaa22d Co-authored-by: tig <585482+tig@users.noreply.github.com>

chatgpt-codex-connector · 2026-05-17T22:00:56Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

Copilot · 2026-05-17T22:02:56Z

@copilot it's still not working. Plus when I click on a list item in the popover list, it dismisses without selecting the autocomplete item i clicked on.

Study how TextView does th...

Rewrote the completion popup properly in 64356e4. The root cause was that TG's Popover intercepts character keys internally (before the KeyDown event fires) — they never reach any event handler. Navigation keys (arrows) do pass through. I confirmed this with diagnostic testing.

The fix follows the PopupAutocomplete.ProcessKey pattern from TG:

Popover is Enabled = false — visual-only overlay, Editor retains keyboard focus
HandleCompletionKey handles ALL keys when completion is active: character keys are inserted directly into the document and the list is refreshed; arrows update ListView.SelectedItem + SetNeedsDraw; Enter/Tab accept; Esc/Backspace handled too
HandleCompletionMouse detects mouse clicks in the Popover's screen frame via Editor.OnMouseEvent — single-click on an item accepts the completion
Arrow key visual updates now call SetNeedsDraw on both the ListView AND the Popover

All 479 unit tests + 236 integration tests pass.

Co-authored-by: tig <585482+tig@users.noreply.github.com>

chatgpt-codex-connector · 2026-05-17T22:06:03Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

Copilot · 2026-05-17T22:06:05Z

@copilot resolve the merge conflicts in this pull request

Merge conflicts resolved in d76c128. Two conflicts in Editor.Commands.cs (kill-ring commands + completion-aware editing commands) and Editor.Keyboard.cs (completion key interception + kill-ring tracking in OnKeyDown) were merged to preserve both features. All 479 unit tests + 252 integration tests pass.

tig · 2026-05-18T03:15:04Z

@copilot resolve the merge conflicts in this pull request

Co-authored-by: tig <585482+tig@users.noreply.github.com>

Copilot · 2026-05-18T03:17:48Z

@copilot resolve the merge conflicts in this pull request

Merge conflicts resolved in c75404f. Two files had conflicts:

examples/ted/TedApp.cs — merged AutoComplete setting with new Save(_configPath) signature from file-io PR
specs/public-api.md — merged both completion and file-io API sections + changelog entries

All 486 unit tests + 262 integration tests pass.

Initial plan

6b18c52

Copilot AI assigned Copilot and tig May 17, 2026

Copilot AI linked an issue May 17, 2026 that may be closed by this pull request

Editor: in-editor completion / autocomplete popup #145

Open

6 tasks

Copilot started work on behalf of tig May 17, 2026 14:33 View session

Copilot AI and others added 2 commits May 17, 2026 14:43

fix: dispose PopoverMenu before recreating; fix DEC-009 reference in …

d42c176

…decisions.md; apply jb cleanup Agent-Logs-Url: https://github.com/gui-cs/Editor/sessions/dddd5eaf-c7d7-40bb-866d-9961401a391b Co-authored-by: tig <585482+tig@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add in-editor autocomplete popup for Editor component~~ feat: in-editor completion / autocomplete popup May 17, 2026

Copilot finished work on behalf of tig May 17, 2026 14:48

Copilot AI requested a review from tig May 17, 2026 14:48

tig requested changes May 17, 2026

View reviewed changes

Comment thread examples/ted/TedApp.cs Outdated

Copilot started work on behalf of tig May 17, 2026 15:43 View session

fix: disable autocomplete by default in ted; add Auto Complete checkb…

449334d

…ox in Settings dialog Agent-Logs-Url: https://github.com/gui-cs/Editor/sessions/cfa1ac33-d4c6-44f9-a99b-c6368a9297bd Co-authored-by: tig <585482+tig@users.noreply.github.com>

Copilot finished work on behalf of tig May 17, 2026 15:47

Copilot AI requested a review from tig May 17, 2026 15:47

Copilot started work on behalf of tig May 17, 2026 16:15 View session

fix: move Auto Complete checkbox from Tab Settings to Config tab in S…

8f4d77d

…ettings dialog Agent-Logs-Url: https://github.com/gui-cs/Editor/sessions/e681778e-94f5-49ce-a7fc-8316bcd4a183 Co-authored-by: tig <585482+tig@users.noreply.github.com>

Copilot finished work on behalf of tig May 17, 2026 16:17

Copilot started work on behalf of tig May 17, 2026 16:20 View session

tig and others added 2 commits May 17, 2026 12:23

Merge branch 'copilot/add-editor-autocomplete-functionality' of https…

f86ad3a

…://github.com/gui-cs/Editor into copilot/add-editor-autocomplete-functionality

fix: CLAUDE.md compliance — remove dead Esc handler, fix Allman brace…

45a1e09

…s in tests Agent-Logs-Url: https://github.com/gui-cs/Editor/sessions/979aa238-ec63-48d4-8db2-5a3cac276f01 Co-authored-by: tig <585482+tig@users.noreply.github.com>

This comment was marked as outdated.

Sign in to view

Copilot finished work on behalf of tig May 17, 2026 16:26

tig added 2 commits May 17, 2026 12:47

Merge branch 'copilot/add-editor-autocomplete-functionality' of https…

8762c34

…://github.com/gui-cs/Editor into copilot/add-editor-autocomplete-functionality

code cleanup

dc8fcbd

Copilot finished work on behalf of tig May 17, 2026 19:44

Merge branch 'develop' into copilot/add-editor-autocomplete-functiona…

7008d94

…lity

Copilot started work on behalf of tig May 17, 2026 20:59 View session

chatgpt-codex-connector Bot reviewed May 17, 2026

View reviewed changes

Comment thread src/Terminal.Gui.Editor/Editor.Completion.cs

Comment thread src/Terminal.Gui.Editor/Editor.Completion.cs

docs: fix XML doc and comment per code review feedback

8456288

Agent-Logs-Url: https://github.com/gui-cs/Editor/sessions/ca58f879-5dc4-433d-8e77-2c1161ff8745 Co-authored-by: tig <585482+tig@users.noreply.github.com>

Copilot finished work on behalf of tig May 17, 2026 21:15

Copilot started work on behalf of tig May 17, 2026 21:30 View session

Copilot finished work on behalf of tig May 17, 2026 22:03

Copilot started work on behalf of tig May 17, 2026 22:03 View session

Merge develop: resolve conflicts (kill-ring + completion)

d76c128

Co-authored-by: tig <585482+tig@users.noreply.github.com>

Copilot finished work on behalf of tig May 17, 2026 22:06

Copilot started work on behalf of tig May 18, 2026 03:15 View session

Merge origin/develop: resolve conflicts in TedApp.cs and public-api.md

c75404f

Co-authored-by: tig <585482+tig@users.noreply.github.com>

Copilot finished work on behalf of tig May 18, 2026 03:18

Conversation

Copilot AI commented May 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tig left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI commented May 17, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

tig commented May 17, 2026

Uh oh!

Copilot AI commented May 17, 2026

Uh oh!

tig commented May 17, 2026

Uh oh!

This comment was marked as outdated.

tig commented May 17, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 17, 2026

Uh oh!

Copilot AI commented May 17, 2026

Uh oh!

tig commented May 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented May 17, 2026

Uh oh!

Copilot AI commented May 17, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 17, 2026

Uh oh!

tig commented May 17, 2026

Uh oh!

tig commented May 17, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 17, 2026

Uh oh!

Copilot AI commented May 17, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 17, 2026

Uh oh!

Copilot AI commented May 17, 2026

Uh oh!

tig commented May 18, 2026

Uh oh!

Copilot AI commented May 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented May 17, 2026 •

edited

Loading