This repository was archived by the owner on May 9, 2022. It is now read-only.
Add support for disabled tags for commands as data attribute#15
Open
ankit wants to merge 29 commits intoguardian:masterfrom
Open
Add support for disabled tags for commands as data attribute#15ankit wants to merge 29 commits intoguardian:masterfrom
ankit wants to merge 29 commits intoguardian:masterfrom
Conversation
Update active state of buttons when disabled
add apache v2 license
Remove button selector
Build: Updates Plumber and the Travis/Saucelabs test matrix
Allow Command-Value to be passed through to Scribe
Contributor
|
Maybe |
Author
|
sounds good, i will look into adding a test and running the test suite |
|
+1 |
Contributor
|
Hi @ankit are you still interested in completing this PR? |
Author
|
Hi @rrees, yes most definitely! Hopefully I can find some time to set up the test suite..sorry for the delay :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to add support for
data-disabled-tagsto disable a command inside specific tags. For example, this will let one disable inserting images inside a table. Or, disable inserting lists inside code.Maybe there is a better name for the attribute =]