For embedder access to image bucket, use grantRead and scope to test/prod#4653
Merged
joelochlann merged 3 commits intomainfrom Mar 9, 2026
Merged
For embedder access to image bucket, use grantRead and scope to test/prod#4653joelochlann merged 3 commits intomainfrom
grantRead and scope to test/prod#4653joelochlann merged 3 commits intomainfrom
Conversation
grantRead and scope to test/prod
ellenmuller
approved these changes
Mar 9, 2026
|
Seen on cropper (merged by @joelochlann 9 minutes and 50 seconds ago) Please check your changes! |
|
Seen on metadata-editor, image-loader, kahuna, media-api (merged by @joelochlann 9 minutes and 56 seconds ago) Please check your changes! |
|
Seen on auth, thrall, usage (merged by @joelochlann 10 minutes and 2 seconds ago) Please check your changes! |
|
Seen on collections, leases (merged by @joelochlann 10 minutes and 9 seconds ago) Please check your changes! |
1 similar comment
|
Seen on collections, leases (merged by @joelochlann 10 minutes and 9 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benefits:
Listpermissions which should mean we don't get spurious errors when objects don't exist (see AWS docs). We've only ever seen this twice in production (not quite sure why?) but still good to fixtesting