Skip to content

Remove container check in Card #15981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abeddow91 wants to merge 3 commits into
base: main
Choose a base branch
from
+5 −4
Open

Remove container check in Card #15981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d55e779
Determine trail text visibility at the container level rather
abeddow91 May 27, 2026
4e255cc
Remove need to check for isMoreGalleriesOnwardContent in card when de…
abeddow91 May 27, 2026
f5450af
Remove audio media check as this is handled by an exception in CARD
abeddow91 May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions dotcom-rendering/src/components/Card/Card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,9 +602,7 @@ export const Card = ({
return 'tablet';
};

const shouldShowTrailText = isMoreGalleriesOnwardContent
? media?.type !== 'podcast' && isOnwardSplash
: media?.type !== 'podcast';
const shouldShowTrailText = media?.type !== 'podcast';

/**
* Determines the gap of between card components based on card properties
Expand Down
5 changes: 4 additions & 1 deletion dotcom-rendering/src/components/MoreGalleries.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ const getDefaultCardProps = (
trail: TrailType,
discussionApiUrl: string,
format: ArticleFormat,
showTrailText: boolean,
serverTime?: number,
) => {
const defaultProps: CardProps = {
Expand Down Expand Up @@ -189,7 +190,7 @@ const getDefaultCardProps = (
branding: trail.branding,
serverTime,
imageLoading: 'lazy',
trailText: trail.trailText,
trailText: showTrailText ? trail.trailText : undefined,
showAge: false,
showTopBarDesktop: false,
showTopBarMobile: false,
Expand Down Expand Up @@ -238,6 +239,7 @@ export const MoreGalleries = (props: Props) => {
firstTrail,
props.discussionApiUrl,
props.format,
true,
props.serverTime,
)}
/>
Expand All @@ -261,6 +263,7 @@ export const MoreGalleries = (props: Props) => {
trail,
props.discussionApiUrl,
props.format,
false,
props.serverTime,
)}
mediaSize="medium"
Expand Down
Loading