World Cup 2026 tagged article navigation#15956
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
Jakeii
added
documentation
Jakeii
added
feature
github-actions
Bot
removed
the
run_chromatic
Jakeii
changed the title
github-actions
Bot
removed
the
run_chromatic
Co-authored-by: DanielCliftonGuardian <110032454+DanielCliftonGuardian@users.noreply.github.com>
Jakeii
force-pushed
the
jlk/world-cup-2026-subnav-articles
branch
from
0d59a78 to
8b565eb
Compare
| }, | ||
| ] satisfies DirectoryPageNavConfig[]; | ||
|
|
||
| const getPlatformColour = ( |
There was a problem hiding this comment.
This is what I came up with to support the different colour on apps, I did consider it might be better to extend the palette declaration to support different colours based on renderingTarget, but if this is the only case where we need it probably it's not worth the extra complexity.
Also a different app component entirely didn't seem like the right move either as it's just colours that are different!
There was a problem hiding this comment.
Your solutions looks very sensible to me 👍
| }; | ||
|
|
||
| export const DirectoryPageNavIsland = (args: Props) => ( | ||
| <Island priority="feature" defer={{ until: 'visible' }}> |
There was a problem hiding this comment.
It now needs to be an island so it can disable the native article "swipe to next article" when scrolling the nav via bridget.
github-actions
Bot
removed
the
run_chromatic
| pageTags?: TagType[]; | ||
| }; | ||
|
|
||
| export const DirectoryPageNavIsland = (args: Props) => ( |
There was a problem hiding this comment.
Did you created this component to avoid repeating to wrap the component by Island in all the places it's used?
| }, | ||
| ] satisfies DirectoryPageNavConfig[]; | ||
|
|
||
| const getPlatformColour = ( |
There was a problem hiding this comment.
Your solutions looks very sensible to me 👍
3 participants
What does this change?
Create a variant of the header added in #15714 for articles without the header, instead with a prominent first nav item with an icon.
There's a different colour scheme for apps, and the component needs to become an island so that it can disable the native app "swipe to next article" feature when interactive with the nav.
Why?
Work related to #15704
Screenshots