Skip to content

Address carousel accessibility violations identified by Chromatic #15910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
SiAdcock wants to merge 3 commits into
base: main
Choose a base branch
from
+7 −5
Draft

Address carousel accessibility violations identified by Chromatic #15910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9005fc
move carousel aria from container to ul
SiAdcock May 14, 2026
97aa51e
use carousel id to link controls
SiAdcock May 13, 2026
305803a
add -title suffix to subhead id
SiAdcock May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dotcom-rendering/src/components/Carousel.island.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -927,9 +927,6 @@ export const Carousel = ({
]}
data-component={onwardsSource}
data-link={formatAttrString(heading)}
role="region"
aria-roledescription="carousel"
aria-label={heading}
>
<Header
heading={heading}
Expand All @@ -947,6 +944,9 @@ export const Carousel = ({
<ul
css={carouselStyle}
ref={carouselRef}
aria-label={heading}
role="region"
aria-roledescription="carousel"
data-component={`carousel-small | maxIndex-${maxIndex}`}
data-heatphan-type="carousel"
onTouchStart={isApps ? onTouchStart : undefined}
Expand Down
2 changes: 1 addition & 1 deletion dotcom-rendering/src/components/CarouselNavigationButtons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export const CarouselNavigationButtons = ({
return ReactDOM.createPortal(
<div
role="group"
aria-controls="carousel"
aria-controls={`${sectionId}-carousel`}
aria-label="carousel arrows"
css={buttonStyles}
>
Expand Down
1 change: 1 addition & 0 deletions dotcom-rendering/src/components/ScrollableCarousel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,7 @@ export const ScrollableCarousel = ({
),
stackedCardRowsStyles(shouldStackCards),
]}
id={`${sectionId}-carousel`}
data-heatphan-type="carousel"
onFocus={scrollToCardOnFocus}
{...(isBelowTabletBreakpoint && {
Expand Down
3 changes: 2 additions & 1 deletion dotcom-rendering/src/components/ScrollableProduct.island.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ export const ScrollableProduct = ({ products, format }: Props) => {
<div css={carouselHeader}>
<Subheading
format={format}
id={'at-a-glance'}
id={'at-a-glance-title'}
topPadding={false}
>
At a glance
Expand All @@ -302,6 +302,7 @@ export const ScrollableProduct = ({ products, format }: Props) => {
ref={carouselRef}
css={carouselStyles}
data-heatphan-type="carousel"
id="at-a-glance-carousel"
>
{products.map(
(product: ProductBlockElement, index: number) => (
Expand Down
Loading