Skip to content

Allow clicks below CQL dropdown#126

Open
paperboyo wants to merge 2 commits into
mainfrom
mk-claude-dropdown-overhang
Open

Allow clicks below CQL dropdown#126
paperboyo wants to merge 2 commits into
mainfrom
mk-claude-dropdown-overhang

Conversation

@paperboyo
Copy link
Copy Markdown

Co-authored by Claude Opus 4.6, description written by a human, 48.

What does this change?

Suggestions dropdown has invisible area below where no clicks work:

hover2

I played with this fix and tried to break it, but dismissing by click outside/ESC works, clicking tapping items works, I couldn't break it.

🤖 narrative:

Fix typeahead popover intercepting clicks in empty space below suggestions.

The .Cql__TypeaheadPopoverContainer has height: 100% to support scroll on long lists, but this means it extends well beyond the visible dropdown content. Clicks/taps in this dead space are swallowed by the container instead of reaching elements underneath.

Fix: pointer-events: none on the container, pointer-events: auto on the inner .Cql__TypeaheadPopover. The visible dropdown remains fully interactive; the invisible overflow is click-through.

How has this change been tested?

I tested a patched library in me toy. Also bun happy.

How can we measure success?

No invisible forces at play. World is explainable again. If a tad boring.

@paperboyo paperboyo requested a review from Copilot May 16, 2026 00:43
@paperboyo paperboyo added the fix Departmental tracking: fix label May 16, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 16, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 16, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses an interaction issue where the CQL typeahead popover’s container extended beyond the visible dropdown, swallowing clicks in the empty space below the suggestions and preventing interaction with underlying UI.

Changes:

  • Makes the typeahead popover container click-through by disabling pointer events on the container.
  • Re-enables pointer events on the visible .Cql__TypeaheadPopover so dropdown items remain interactive.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/cql/src/cqlInput/CqlInput.ts
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Departmental tracking: fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants