Skip to content

Fix npm publishing, update sbt-scrooge-typescript, fix npm publish for preview & update TypeScript#213

Open
arelra wants to merge 4 commits into
mainfrom
update-sbt-scrooge-typescript
Open

Fix npm publishing, update sbt-scrooge-typescript, fix npm publish for preview & update TypeScript#213
arelra wants to merge 4 commits into
mainfrom
update-sbt-scrooge-typescript

Conversation

@arelra
Copy link
Copy Markdown
Member

@arelra arelra commented May 15, 2026

Co-authored-by: Marjan K 15894063+marjisound@users.noreply.github.com

Updates sbt-scrooge-typescript to fix the version selection of Typescript.

Currently npm publishing fails as the ScroogeTypescriptGen plugin from scrooge-extras throws an error when running it's internal tsc command.

The generated tsconfig.json uses a target of ES5, however it then runs the global version of tsc which (now) resolves to v6, rather than the expected version of v5.

The correct selection of TypeScript by ScroogeTypescriptGen was fixed (many years ago) here:
guardian/scrooge-extras#25

However content-atom is still on an old version with this bug.

Full explanation here:
guardian/scrooge-extras#59

Add a tag via setting scroogeTypescriptPublishTag to the npm publish step for preview versions. This has become mandatory and without it npm publishing fails.

Update typescript to v5.9.3

gu-scala-library-release Bot added a commit that referenced this pull request May 15, 2026
…9 published by arelra

arelra published release version 11.0.1-PREVIEW.update-sbt-scrooge-typescript.2026-05-15T1542.974b0559
using gha-scala-library-release-workflow: https://github.com/guardian/gha-scala-library-release-workflow

Release-Version: 11.0.1-PREVIEW.update-sbt-scrooge-typescript.2026-05-15T1542.974b0559
Release-Initiated-By: https://github.com/arelra
Release-Workflow-Run: https://github.com/guardian/content-atom/actions/runs/25926886336
Release-Notes: #213
@gu-scala-library-release
Copy link
Copy Markdown
Contributor

@arelra has published a preview version of this PR with release workflow run #51, based on commit 974b055:

11.0.1-PREVIEW.update-sbt-scrooge-typescript.2026-05-15T1542.974b0559

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the update-sbt-scrooge-typescript branch, or use the GitHub CLI command:

gh workflow run release.yml --ref update-sbt-scrooge-typescript

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

…t-to-es6.2026-05-15T1456.a0d2ee45

Fixes tsc compilation error

Co-authored-by: Marjan K <15894063+marjisound@users.noreply.github.com>
@arelra arelra force-pushed the update-sbt-scrooge-typescript branch from 974b055 to 3513183 Compare May 15, 2026 16:19
gu-scala-library-release Bot added a commit that referenced this pull request May 15, 2026
…2 published by arelra

arelra published release version 11.0.1-PREVIEW.update-sbt-scrooge-typescript.2026-05-15T1622.35131832
using gha-scala-library-release-workflow: https://github.com/guardian/gha-scala-library-release-workflow

Release-Version: 11.0.1-PREVIEW.update-sbt-scrooge-typescript.2026-05-15T1622.35131832
Release-Initiated-By: https://github.com/arelra
Release-Workflow-Run: https://github.com/guardian/content-atom/actions/runs/25928787771
Release-Notes: #213
@gu-scala-library-release
Copy link
Copy Markdown
Contributor

@arelra has published a preview version of this PR with release workflow run #52, based on commit 3513183:

11.0.1-PREVIEW.update-sbt-scrooge-typescript.2026-05-15T1622.35131832

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the update-sbt-scrooge-typescript branch, or use the GitHub CLI command:

gh workflow run release.yml --ref update-sbt-scrooge-typescript

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

@arelra arelra force-pushed the update-sbt-scrooge-typescript branch from 3513183 to 4a5d840 Compare May 15, 2026 16:44
gu-scala-library-release Bot added a commit that referenced this pull request May 15, 2026
…d published by arelra

arelra published release version 11.0.1-PREVIEW.update-sbt-scrooge-typescript.2026-05-15T1701.fcb24d5d
using gha-scala-library-release-workflow: https://github.com/guardian/gha-scala-library-release-workflow

Release-Version: 11.0.1-PREVIEW.update-sbt-scrooge-typescript.2026-05-15T1701.fcb24d5d
Release-Initiated-By: https://github.com/arelra
Release-Workflow-Run: https://github.com/guardian/content-atom/actions/runs/25930601117
Release-Notes: #213
@gu-scala-library-release
Copy link
Copy Markdown
Contributor

@arelra has published a preview version of this PR with release workflow run #53, based on commit fcb24d5:

11.0.1-PREVIEW.update-sbt-scrooge-typescript.2026-05-15T1701.fcb24d5d

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the update-sbt-scrooge-typescript branch, or use the GitHub CLI command:

gh workflow run release.yml --ref update-sbt-scrooge-typescript

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

@arelra arelra changed the title Update sbt-scrooge-typescript Update sbt-scrooge-typescript, npm publish & typescript May 15, 2026
arelra and others added 2 commits May 22, 2026 15:01
Co-authored-by: Marjan K <15894063+marjisound@users.noreply.github.com>
…ogeTypescriptPublishTag for scrooge-extras

Co-authored-by: Marjan K <15894063+marjisound@users.noreply.github.com>
@arelra arelra force-pushed the update-sbt-scrooge-typescript branch from fcb24d5 to 75164bd Compare May 22, 2026 14:03
gu-scala-library-release Bot added a commit that referenced this pull request May 22, 2026
…e published by arelra

arelra published release version 11.0.1-PREVIEW.update-sbt-scrooge-typescript.2026-05-22T1410.75164bde
using gha-scala-library-release-workflow: https://github.com/guardian/gha-scala-library-release-workflow

Release-Version: 11.0.1-PREVIEW.update-sbt-scrooge-typescript.2026-05-22T1410.75164bde
Release-Initiated-By: https://github.com/arelra
Release-Workflow-Run: https://github.com/guardian/content-atom/actions/runs/26292715461
Release-Notes: #213
@gu-scala-library-release
Copy link
Copy Markdown
Contributor

@arelra has published a preview version of this PR with release workflow run #54, based on commit 75164bd:

11.0.1-PREVIEW.update-sbt-scrooge-typescript.2026-05-22T1410.75164bde

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the update-sbt-scrooge-typescript branch, or use the GitHub CLI command:

gh workflow run release.yml --ref update-sbt-scrooge-typescript

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

gu-scala-library-release Bot added a commit that referenced this pull request May 22, 2026
…f published by arelra

arelra published release version 11.0.1-PREVIEW.update-sbt-scrooge-typescript.2026-05-22T1509.c7e7514f
using gha-scala-library-release-workflow: https://github.com/guardian/gha-scala-library-release-workflow

Release-Version: 11.0.1-PREVIEW.update-sbt-scrooge-typescript.2026-05-22T1509.c7e7514f
Release-Initiated-By: https://github.com/arelra
Release-Workflow-Run: https://github.com/guardian/content-atom/actions/runs/26295730707
Release-Notes: #213
@arelra arelra changed the title Update sbt-scrooge-typescript, npm publish & typescript Update sbt-scrooge-typescript, npm publish for preview & align typescript version May 22, 2026
@arelra arelra changed the title Update sbt-scrooge-typescript, npm publish for preview & align typescript version Update sbt-scrooge-typescript, npm publish for preview & typescript version May 22, 2026
@gu-scala-library-release
Copy link
Copy Markdown
Contributor

@arelra has published a preview version of this PR with release workflow run #56, based on commit c7e7514:

11.0.1-PREVIEW.update-sbt-scrooge-typescript.2026-05-22T1509.c7e7514f

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the update-sbt-scrooge-typescript branch, or use the GitHub CLI command:

gh workflow run release.yml --ref update-sbt-scrooge-typescript

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

@arelra arelra changed the title Update sbt-scrooge-typescript, npm publish for preview & typescript version Fix NPM publishing, update sbt-scrooge-typescript, fix npm publish for preview & update TypeScript May 22, 2026
@arelra arelra changed the title Fix NPM publishing, update sbt-scrooge-typescript, fix npm publish for preview & update TypeScript Fix NPM publishing, update sbt-scrooge-typescript, fix NPM publish for preview & update TypeScript May 22, 2026
Co-authored-by: Marjan K <15894063+marjisound@users.noreply.github.com>
@arelra arelra force-pushed the update-sbt-scrooge-typescript branch from c7e7514 to cad2e04 Compare May 22, 2026 17:34
@arelra arelra changed the title Fix NPM publishing, update sbt-scrooge-typescript, fix NPM publish for preview & update TypeScript Fix npm publishing, update sbt-scrooge-typescript, fix npm publish for preview & update TypeScript May 22, 2026
@arelra arelra marked this pull request as ready for review May 22, 2026 17:42
@arelra arelra requested review from a team as code owners May 22, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant