Fix Typescript release workflow#106
Conversation
Fweddi
force-pushed
the
fp/bump-scrooge-ts
branch
from
abe0bef to
19e74e4
Compare
…by Fweddi Fweddi published release version 13.0.1-PREVIEW.fpbump-scrooge-ts.2025-10-01T1413.19e74e41 using gha-scala-library-release-workflow: https://github.com/guardian/gha-scala-library-release-workflow Release-Version: 13.0.1-PREVIEW.fpbump-scrooge-ts.2025-10-01T1413.19e74e41 Release-Initiated-By: https://github.com/Fweddi Release-Workflow-Run: https://github.com/guardian/apps-rendering-api-models/actions/runs/18165055968 Release-Notes: #106
|
@Fweddi has published a preview version of this PR with release workflow run #20, based on commit 19e74e4: 13.0.1-PREVIEW.fpbump-scrooge-ts.2025-10-01T1413.19e74e41 Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the fp/bump-scrooge-ts branch, or use the GitHub CLI command: gh workflow run release.yml --ref fp/bump-scrooge-ts Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
…by Fweddi Fweddi published release version 13.0.1-PREVIEW.fpbump-scrooge-ts.2025-10-02T0957.15fda4f0 using gha-scala-library-release-workflow: https://github.com/guardian/gha-scala-library-release-workflow Release-Version: 13.0.1-PREVIEW.fpbump-scrooge-ts.2025-10-02T0957.15fda4f0 Release-Initiated-By: https://github.com/Fweddi Release-Workflow-Run: https://github.com/guardian/apps-rendering-api-models/actions/runs/18189690737 Release-Notes: #106
|
@Fweddi has published a preview version of this PR with release workflow run #21, based on commit 15fda4f: 13.0.1-PREVIEW.fpbump-scrooge-ts.2025-10-02T0957.15fda4f0 Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the fp/bump-scrooge-ts branch, or use the GitHub CLI command: gh workflow run release.yml --ref fp/bump-scrooge-ts Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
rtyley
left a comment
rtyley
left a comment
There was a problem hiding this comment.
Looks good! Obviously, just need to update to a non-preview version first.
| addSbtPlugin("com.twitter" % "scrooge-sbt-plugin" % "22.1.0") | ||
|
|
||
| addSbtPlugin("com.gu" % "sbt-scrooge-typescript" % "2.0.0") | ||
| addSbtPlugin("com.gu" % "sbt-scrooge-typescript" % "4.0.0-PREVIEW.fpdowngrade-scrooge.2025-10-02T0939.1433794d") |
There was a problem hiding this comment.
Just need to update this once guardian/scrooge-extras#39 is merged and released, so that we can use the non-preview version here!
2 participants
What does this change?
sbt-scrooge-typescripthad TS compilation issues (caused by an old version of Typescript used in the test packages - guardian/scrooge-extras#42) and Thrift serialisation issues (resolved by downgrading Thrift - guardian/scrooge-extras#39).This meant that we were unable to publish
apps-rendering-api-modelsto NPM:Version 4.0.0 of
sbt-scrooge-typescript(guardian/scrooge-extras#39) should resolve these issues.Testing
✅ Upgrading to
4.0.0should unblock the release workflow: https://github.com/guardian/apps-rendering-api-models/actions/runs/18189690737✅ And unblock downstream consumption by DCR: guardian/dotcom-rendering#14533