fix: add DELETE support and Content-Type header in make_request#50
Merged
Conversation
SergioLangaritaBenitez
added a commit
that referenced
this pull request
Jun 25, 2026
* Use user token instead of service token in the invocation (#45) * pagination option added * adapt fdl scipt path * absolute path posibility added * client_id as optional argument * client_id default value * Update readme * clean code and set default values * Updating versions/notes for 1.3.3-beta1 release * Updating versions/notes for 1.3.3-beta1 release * use token of the user instead of the service --------- Co-authored-by: Estíbaliz Parcero <5576714+esparig@users.noreply.github.com> * feat: implement missing API client methods and add unit tests (#47) * pagination option added * adapt fdl scipt path * absolute path posibility added * client_id as optional argument * client_id default value * Update readme * clean code and set default values * Updating versions/notes for 1.3.3-beta1 release * Updating versions/notes for 1.3.3-beta1 release * use token of the user instead of the service * feat: implement missing API client methods and add unit tests - Add 21 new methods to client.py (health, deployments, volumes, buckets, metrics, quotas, system_logs) - Add load_config utility function in _utils.py - Fix make_request UnboundLocalError on POST/PUT without data - Add 29 unit tests across test_client.py and test_utils.py - Fix all style issues (flake8 clean across project) * feat: add federation API client methods and tests (#49) * pagination option added * adapt fdl scipt path * absolute path posibility added * client_id as optional argument * client_id default value * Update readme * clean code and set default values * Updating versions/notes for 1.3.3-beta1 release * Updating versions/notes for 1.3.3-beta1 release * use token of the user instead of the service * feat: implement missing API client methods and add unit tests - Add 21 new methods to client.py (health, deployments, volumes, buckets, metrics, quotas, system_logs) - Add load_config utility function in _utils.py - Fix make_request UnboundLocalError on POST/PUT without data - Add 29 unit tests across test_client.py and test_utils.py - Fix all style issues (flake8 clean across project) * feat: add federation API client methods and tests * fix: add DELETE support and Content-Type header in make_request (#50) * fix: add DELETE support and Content-Type header in make_request * fix: update test_make_request_post to expect Content-Type header * Dev slangarita (#52) * fix: add DELETE support and Content-Type header in make_request * fix: update test_make_request_post to expect Content-Type header --------- Co-authored-by: Estíbaliz Parcero <5576714+esparig@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descripción
Arregla el envío de body en peticiones DELETE en .
Cambios
Problema
Sin estos cambios, enviaba DELETE sin body, el servidor respondía 400 y el miembro no se eliminaba.