refactor: add type-safe WrapGcpInitClient and fix missing Scope.Region #993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add WrapGcpInitClient helper matching AWS's WrapAwsInitClient pattern - Add GCP constants (DefaultBatchSize, DefaultWaitTimeout) for consistency - Improve GCP adapter documentation to match AWS quality - Update gcs_bucket.go to use WrapGcpInitClient with proper error handling - Replace silent failures with panics for programming errors
james00012
force-pushed
the
refactor/gcp-adapter-type-safety
branch
from
b221249 to
9853a58
Compare
These resources were missing r.Scope.Region = cfg.Region in InitClient, causing empty region in logs (e.g., "Deleting 5 dynamodb in " instead of "Deleting 5 dynamodb in us-east-1"). Affected resources: - apigateway - apigatewayv2 - dynamodb - ebs - ec2_egress_only_igw - network_firewall_resource_policy - rds - rds_parameter_group - rds_subnet_group
james00012
changed the title
denis256
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
GCP Adapter:
WrapGcpInitClienthelper matching AWS'sWrapAwsInitClientpatternDefaultBatchSizeandDefaultWaitTimeoutconstantsgcs_bucket.goto use the new helperAWS Resources (9 files):
r.Scope.Region = cfg.Regionin InitClientTest plan
go build ./...passesgo test ./...passes