Update Alpine base, fix Jamulus version download#28
Open
Procsiab wants to merge 1 commit intogrundic:masterfrom
Open
Update Alpine base, fix Jamulus version download#28Procsiab wants to merge 1 commit intogrundic:masterfrom
Procsiab wants to merge 1 commit intogrundic:masterfrom
Conversation
Procsiab
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greetings grundic, I am opening this PR to let you know that with the proposed change to the Dockerfile it is possible to successfully build a container image for the latest "stable" version of Jamulus.
I also used an environment variable to address the specific version tag, for managing builds for specific versions more easily.
If for whaterver reason this PR does not fit within your use case, please close it so that it won't add noise.
Regards!