Skip to content

Revert "increase ready for server channel timeout for outlier_detection , custom_lb, round_robin test" #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sergiitk wants to merge 1 commit into from
Closed

Revert "increase ready for server channel timeout for outlier_detection , custom_lb, round_robin test" #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions tests/custom_lb_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,12 +118,7 @@ def test_custom_lb_config(self):
self.setupServerBackends()

with self.subTest("7_start_test_client"):
test_client: _XdsTestClient = self.startTestClient(
test_server,
wait_for_server_channel_ready_timeout=datetime.timedelta(
minutes=10
),
)
test_client: _XdsTestClient = self.startTestClient(test_server)

with self.subTest("8_test_client_xds_config_exists"):
self.assertXdsConfigExists(test_client)
Expand Down
9 changes: 1 addition & 8 deletions tests/outlier_detection_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
import datetime
import logging
from typing import List

Expand Down Expand Up @@ -118,13 +117,7 @@ def test_outlier_detection(self) -> None:

test_client: _XdsTestClient
with self.subTest("07_start_test_client"):
test_client = self.startTestClient(
test_servers[0],
qps=_QPS,
wait_for_server_channel_ready_timeout=datetime.timedelta(
minutes=10
),
)
test_client = self.startTestClient(test_servers[0], qps=_QPS)

with self.subTest("08_test_client_xds_config_exists"):
self.assertXdsConfigExists(test_client)
Expand Down
9 changes: 1 addition & 8 deletions tests/round_robin_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
import dataclasses
import datetime
import logging
from typing import List

Expand Down Expand Up @@ -57,12 +55,7 @@ def test_round_robin(self) -> None:

test_client: _XdsTestClient
with self.subTest("07_start_test_client"):
test_client = self.startTestClient(
test_servers[0],
wait_for_server_channel_ready_timeout=datetime.timedelta(
minutes=10
),
)
test_client = self.startTestClient(test_servers[0])

with self.subTest("08_test_client_xds_config_exists"):
self.assertXdsConfigExists(test_client)
Expand Down