Remove multiple GRPC_*_EXPERIMENTAL_* env variables#169
Open
Remove multiple GRPC_*_EXPERIMENTAL_* env variables#169
Conversation
These variables were set to "true", now being removed: - GRPC_EXPERIMENTAL_ENABLE_OUTLIER_DETECTION - GRPC_EXPERIMENTAL_XDS_CUSTOM_LB_CONFIG - GRPC_EXPERIMENTAL_XDS_ENABLE_OVERRIDE_HOST - GRPC_XDS_EXPERIMENTAL_ENABLE_RETRY - GRPC_XDS_EXPERIMENTAL_NEW_SERVER_API - GRPC_XDS_EXPERIMENTAL_RBAC - GRPC_XDS_EXPERIMENTAL_SECURITY_SUPPORT - GRPC_XDS_EXPERIMENTAL_V3_SUPPORT
Member
Author
|
It's difficult to track all of them, but here's a few relevant changes: |
Member
Author
|
Oldest java:
Oldest cpp: |
XuanWang-Amos
approved these changes
Apr 9, 2025
ejona86
approved these changes
Apr 9, 2025
Member
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
I expect GRPC_XDS_EXPERIMENTAL_ENABLE_RING_HASH could also be removed, but I don't think this needs to be perfect (removing the ones you are is still a win).
Member
|
You should leave GRPC_XDS_EXPERIMENTAL_RBAC. Node is going to need that soon. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These variables were set to "true", now being removed:
The following env variables are kept and are set to "true":