Fix mapping of well-known types when compiling a FileDescriptionSet#2647
Open
MarkusPettersson98 wants to merge 1 commit into
Open
Fix mapping of well-known types when compiling a FileDescriptionSet#2647MarkusPettersson98 wants to merge 1 commit into
FileDescriptionSet#2647MarkusPettersson98 wants to merge 1 commit into
Conversation
Respect the recently added `Builder::with_extended_rust_types` when compiling a `FileDescriptionSet` via e.g. `Builder::compile_fds` or `Builder::compile_fds_with_config`. When `with_extended_rust_types` was added, only the code paths compiling .proto files from source were updated to include the extended mappings of well-known types.
MarkusPettersson98
force-pushed
the
support-wkt-compile-fds
branch
from
f2633ee to
0a7661b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Respect the recently added
Builder::with_extended_rust_typeswhen compiling aFileDescriptionSetvia e.g.Builder::compile_fdsorBuilder::compile_fds_with_config.Motivation
When
with_extended_rust_typeswas added in #2544, only the code paths compiling .proto files from source were updated to include the extended mappings of well-known types. This makes it harder to use the option when compiling .proto files using protox, for example.Solution
Duplicate the code path from
Builder::compile_with_configextendingNON_PATH_TYPE_ALLOWLISTwithEXTENDED_NON_PATH_TYPE_ALLOWLISTwhen compiling .proto sources viaBuilder::compile_fds_with_config.